Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make in-product APM alerting links smart (stateful vs serverless) #176252

Merged
merged 10 commits into from
Mar 20, 2024

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Feb 5, 2024

Summary

This is a part of elastic/observability-docs#3622.

Before this PR, all four in-product APM alerting documentation links pointed to https://www.elastic.co/guide/en/kibana/master/apm-alerts.html. This PR updates our in-product links to point to either our Serverless or Stateful documentation, depending on the product type.

Closes elastic/observability-docs#3586.

@bmorelli25 bmorelli25 self-assigned this Feb 5, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@bmorelli25 bmorelli25 requested a review from dedemorton March 18, 2024 22:02
@bmorelli25 bmorelli25 marked this pull request as ready for review March 18, 2024 22:02
@bmorelli25 bmorelli25 requested review from a team as code owners March 18, 2024 22:02
@bmorelli25 bmorelli25 changed the title Separate APM documentation links Make in-product APM alerting links smart (stateful vs serverless) Mar 18, 2024
@bmorelli25 bmorelli25 added release_note:skip Skip the PR/issue when compiling release notes v8.13.1 labels Mar 18, 2024
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming this passes CI. Thanks!!

@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Mar 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@bmorelli25
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cauemarcondes
Copy link
Contributor

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor

@bmorelli25 I pushed a change to your PR, I don't know why but an e2e broke.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 138.4KB 138.7KB +331.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 34.5KB 34.6KB +52.0B
core 391.9KB 392.2KB +331.0B
total +383.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bmorelli25 @dedemorton

@cauemarcondes cauemarcondes merged commit 62aa327 into elastic:main Mar 20, 2024
20 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 20, 2024
…astic#176252)

## Summary

This is a part of
elastic/observability-docs#3622.

Before this PR, all four in-product APM alerting documentation links
pointed to
https://www.elastic.co/guide/en/kibana/master/apm-alerts.html. This PR
updates our in-product links to point to either our Serverless or
Stateful documentation, depending on the product type.

Closes elastic/observability-docs#3586.

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Caue Marcondes <[email protected]>
(cherry picked from commit 62aa327)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 20, 2024
…ss) (#176252) (#179093)

# Backport

This will backport the following commits from `main` to `8.13`:
- [Make in-product APM alerting links smart (stateful vs serverless)
(#176252)](#176252)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brandon
Morelli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-20T18:43:41Z","message":"Make
in-product APM alerting links smart (stateful vs serverless)
(#176252)\n\n## Summary\r\n\r\nThis is a part
of\r\nhttps://github.com/elastic/observability-docs/issues/3622.\r\n\r\nBefore
this PR, all four in-product APM alerting documentation links\r\npointed
to\r\nhttps://www.elastic.co/guide/en/kibana/master/apm-alerts.html.
This PR\r\nupdates our in-product links to point to either our
Serverless or\r\nStateful documentation, depending on the product
type.\r\n\r\nCloses
https://github.com/elastic/observability-docs/issues/3586.\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>\r\nCo-authored-by:
Caue Marcondes
<[email protected]>","sha":"62aa3279dfdfb12112827826b6ff2d76b50fbe96","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-infra_services","v8.14.0","v8.13.1"],"title":"Make
in-product APM alerting links smart (stateful vs
serverless)","number":176252,"url":"https://github.com/elastic/kibana/pull/176252","mergeCommit":{"message":"Make
in-product APM alerting links smart (stateful vs serverless)
(#176252)\n\n## Summary\r\n\r\nThis is a part
of\r\nhttps://github.com/elastic/observability-docs/issues/3622.\r\n\r\nBefore
this PR, all four in-product APM alerting documentation links\r\npointed
to\r\nhttps://www.elastic.co/guide/en/kibana/master/apm-alerts.html.
This PR\r\nupdates our in-product links to point to either our
Serverless or\r\nStateful documentation, depending on the product
type.\r\n\r\nCloses
https://github.com/elastic/observability-docs/issues/3586.\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>\r\nCo-authored-by:
Caue Marcondes
<[email protected]>","sha":"62aa3279dfdfb12112827826b6ff2d76b50fbe96"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176252","number":176252,"mergeCommit":{"message":"Make
in-product APM alerting links smart (stateful vs serverless)
(#176252)\n\n## Summary\r\n\r\nThis is a part
of\r\nhttps://github.com/elastic/observability-docs/issues/3622.\r\n\r\nBefore
this PR, all four in-product APM alerting documentation links\r\npointed
to\r\nhttps://www.elastic.co/guide/en/kibana/master/apm-alerts.html.
This PR\r\nupdates our in-product links to point to either our
Serverless or\r\nStateful documentation, depending on the product
type.\r\n\r\nCloses
https://github.com/elastic/observability-docs/issues/3586.\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>\r\nCo-authored-by:
Caue Marcondes
<[email protected]>","sha":"62aa3279dfdfb12112827826b6ff2d76b50fbe96"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Brandon Morelli <[email protected]>
@bmorelli25 bmorelli25 deleted the obs-doc-link-service branch March 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.13.0 v8.13.1 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kibana links to APM documentaiton
7 participants